Skip to content

⚡ Bolt: Optimize iteration over railwayData#90

Open
OsakaLOOP wants to merge 1 commit intobefore-refractorfrom
bolt-optimize-iteration-3680989735805471630
Open

⚡ Bolt: Optimize iteration over railwayData#90
OsakaLOOP wants to merge 1 commit intobefore-refractorfrom
bolt-optimize-iteration-3680989735805471630

Conversation

@OsakaLOOP
Copy link
Copy Markdown
Owner

💡 What:

  • Replaced nested loops and Object.values(railwayData).forEach with $O(1)$ Hash Map lookups inside TripsPage.tsx.
  • Converted functional .forEach mapping into single-pass for...in loops with break conditions and Object.prototype.hasOwnProperty.call() checks in WalkTripEditor.tsx and GlobalSearchModal.tsx.

🎯 Why:
The codebase frequently processes a massive railwayData state object. Using Object.keys(), Object.values(), or Object.entries() creates huge temporary arrays that stress the garbage collector. Additionally, $O(N^2)$ iterations inside React render loops can cause UI thread blocking and lag.

📊 Impact:

  • TripsPage: Reduces computational overhead from $O(\text{Trips} \times \text{Lines} \times \text{Stations})$ to $O(\text{Lines} \times \text{Stations} + \text{Trips})$ during re-renders, vastly improving page load time when viewing large trip histories.
  • WalkTripEditor: Prevents full loop evaluation, immediately exiting when both startId and endId match.
  • GlobalSearchModal: Prevents creating huge [lineKey, lineData] arrays on every keystroke, directly improving typing responsiveness.

🔬 Measurement:

  • Ran npm run lint and npm run build locally successfully.
  • No tests were broken (npx tsx test_find_station.ts passes).

PR created automatically by Jules for task 3680989735805471630 started by @OsakaLOOP

Co-authored-by: OsakaLOOP <68284076+OsakaLOOP@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant